I think he'd have been a bloody good one, especially if one or both of Finduilas & Boromir survived. I think he might have made a passable father under those circumstances too. The favouritism towards Boromir, his heir, would have played out better if Finduilas lived & was even handed. (I haven't looked at the timeline of late, but if Finduilas had lived there might have been other children too.)

Reading the quotation, it strikes me that he says his own master.

...shortly after Faramir has had to tell his (mid-to-late-teenage) children about the pyre.

Aie. Suicide & madness are now rather loaded for me. I'm glad now I never had any children.